On Wed, 15 Dec 2010 01:34:33 -0200 Raphael Kubo da Costa <[email protected]>
said:
> (CURLOPT_POSTFIELDS already implies CURLOPT_POST)
>
> libcurl does the following when parsing CURLOPT_POST:
>
> if(va_arg(param, long)) {
> data->set.httpreq = HTTPREQ_POST;
> data->set.opt_no_body = FALSE; /* this is implied */
> }
> else
> data->set.httpreq = HTTPREQ_GET;
>
> So at first glance your patch seems to turn the POST request into a
> GET one (I haven't worked on this stuff for a few months, so I might
> be wrong here).
>
> Quoting libcurl's documentation for curl_easy_setopt:
>
> If you want to do a zero-byte POST, you need to set
> CURLOPT_POSTFIELDSIZE explicitly to zero, as simply setting
> CURLOPT_POSTFIELDS to NULL or "" just effectively disables the
> sending of the specified string. libcurl will instead assume that
> you'll send the POST data using the read callback!
>
> Doesn't it make more sense to unconditionally set at least
> CURLOPT_POSTFIELDSIZE in this function (if data == NULL, set it to 0)?
i did just that :) in sv.
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [email protected]
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
