hermet, thanks for your good suggestion. as your suggestion, i revised APIs.
but now center coordinates are useless, because rotated map is grid images. so center coordinates are decided by each grid image. what do you think about this? /** * Set the rotate degree of the map * * @param obj The map object * @param dx amount of degrees from 0.0 to 360.0 to rotate arount X axis. * @param dy amount of degrees from 0.0 to 360.0 to rotate arount Y axis. * @param dz amount of degrees from 0.0 to 360.0 to rotate arount Z axis. * * @ingroup Map */ EAPI void elm_map_rotate_set(Evas_Object *obj, double dx, double dy, double dz) EINA_ARG_NONNULL(1); /** * Get the rotate degree of the map * * @param obj The map object * @param dx amount of degrees from 0.0 to 360.0 to rotate arount X axis. * @param dy amount of degrees from 0.0 to 360.0 to rotate arount Y axis. * @param dz amount of degrees from 0.0 to 360.0 to rotate arount Z axis. * * @ingroup Map */ EAPI void elm_map_rotate_get(const Evas_Object *obj, double *dx, double *dy, double *dz) EINA_ARG_NONNULL(1, 2, 3); /** * Convert a pixel coordinate into a roated pixcel coordinate. * * @param obj The map object * @param x x to rotate. * @param y y to rotate. * @param z z to rotate. * @param dx amount of degrees from 0.0 to 360.0 to rotate arount X axis. * @param dy amount of degrees from 0.0 to 360.0 to rotate arount Y axis. * @param dz amount of degrees from 0.0 to 360.0 to rotate arount Z axis. * @param xx rotated x. * @param yy rotated y. * @param zz rotated z. * * @ingroup Map */ API void elm_map_utils_rotate_coord(const Evas_Object *obj, const Evas_Coord x, const Evas_Coord y, const double z, const double dx, const double dy, const double dz, Evas_Coord *xx, Evas_Coord *yy, Evas_Coord *zz) EINA_ARG_NONNULL(1, 8, 9, 10); 2011/4/20 ChunEon Park <her...@naver.com> > how about just rotate_set as you add elm_map_rotate_get > > > > elm_map_rotate_set(obj, center_x, center_y, center_z, degree_x, degree_y, > degree_z); > > > > and I think it will be better if it returns the above arguments also. > > > > elm_map_rotate_get(const Evas_Object *obj, ¢er_x, ¢er_y, ¢er_z, > °ree_x, °ree_y, °ree_z); > > Thanks. > > > > ------------------------------------ > Let's run together for the best moment! > > -Regards, Hermet- > > > > -----Original Message----- > *From:* "sangho park"<gouach...@gmail.com> > *To:* "Daniel Juyung Seo"<seojuyu...@gmail.com> > *Cc:* enlightenment-devel@lists.sourceforge.net > *Sent:* 11-04-19(화) 11:43:33 > *Subject:* Re: [E-devel] [Patch] elm_map rotate featurethanks for your > lightning comments~~ :) > > 1) I'll apply const ~ > 2) the reference code is 'evas_map_util_3d_rotate'. i can't find another > api > which is containing rotate keyword. actually, I have a plan to support 3d > map. anyway, what is your recommendation? > > On Tue, Apr 19, 2011 at 11:33 AM, Daniel Juyung Seo <seojuyu...@gmail.com > >wrote: > > > Video looks good! > > It's getting better and better. > > > > Just two comments from my side. > > > > 1) > > > > >> + EAPI double elm_map_rotate_get(Evas_Object *obj) > > EINA_ARG_NONNULL(1); > > According to EFL coding convention, we add "const" to getter's parameter > > like below: > > EAPI double elm_map_rotate_get(const Evas_Object *obj) > > EINA_ARG_NONNULL(1); > > > > Actually this needs to be done to other APIs. > > EAPI const char *elm_map_name_address_get(Elm_Map_Name *name) > > EINA_ARG_NONNULL(1); > > EAPI void elm_map_name_region_get(Elm_Map_Name *name, > > double *lon, double *lat) EINA_ARG_NONNULL(1); > > > > 2) > > >> + EAPI void elm_map_util_3d_rotate(Evas_Object *obj, > > double dx, double dy, double dz, Evas_Coord cx, Evas_Coord cy, Evas_Coord > > cz, Evas_Coord *ox, Evas_Coord *oy, Evas_Coord *oz) EINA_ARG_NONNULL(1, > 8, > > 9, 10); > > From youtube video, it looks like a 2d rotation. > > Why it's named 3d_rotate? > > > > Thanks. > > Daniel Juyung Seo (SeoZ) > > > > On Tue, Apr 19, 2011 at 11:25 AM, sangho park <gouach...@gmail.com> > wrote: > > > >> Dear all, > >> > >> I just implement map rotate feature. > >> it's the start of turn-by-turn navigation. :) > >> > >> because of some added APIs, I need your reviews. > >> > >> you can find demo youtube. > >> http://www.youtube.com/watch?v=juxKrrHVU4U > >> > >> pls review this patch. > >> > >> Thanks. > >> BR > >> > >> > >> > ------------------------------------------------------------------------------ > >> Benefiting from Server Virtualization: Beyond Initial Workload > >> Consolidation -- Increasing the use of server virtualization is a top > >> priority.Virtualization can reduce costs, simplify management, and > improve > >> application availability and disaster protection. Learn more about > >> boosting > >> the value of server virtualization. > http://p.sf.net/sfu/vmware-sfdev2dev > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > >> > > > > ------------------------------------------------------------------------------ > Benefiting from Server Virtualization: Beyond Initial Workload > Consolidation -- Increasing the use of server virtualization is a top > priority.Virtualization can reduce costs, simplify management, and improve > application availability and disaster protection. Learn more about boosting > > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel