…But we wouldn't want to require the arguments to the set constructor to require instantiation itself/themselves, right? If a set has to be constructed with an Iterable, and cannot (also) be constructed with individual atoms, then you'll end up with use cases like Set(['foo', 'bar', 'baz']), which requires two constructions, one of which is essentially a waste. If allowing both forms of the constructor is distasteful, then why not just go with the multiple parameters, approach, and implement toSet() as a method on appropriate Iterables?
-Michael A. Smith On Sun, Feb 12, 2012 at 9:29 PM, Erik Arvidsson <erik.arvids...@gmail.com> wrote: > The default argument should probably just be an iterable. > > On Feb 12, 2012 4:50 PM, "Oliver Hunt" <oli...@apple.com> wrote: >> >> I saw a reference to it being modified to take an array(-like?) as a >> parameter. While I can see an argument in favour of a single array argument >> I can also see using a set of parameters that initially populate the set. >> We just shouldn't allow both (and introduce another version of the horror >> that is the Array constructor). >> >> With the existence of the spread operator I think that there's a good >> argument in favour of the multiple parameters approach. >> >> --Oliver >> >> >> On Feb 12, 2012, at 4:33 PM, Peter Michaux wrote: >> >> > In the proposal, the Set constructor takes no arguments. >> > >> > http://wiki.ecmascript.org/doku.php?id=harmony:simple_maps_and_sets >> > >> > Could it take a list of initial elements to be included in the set? >> > >> > var s = new Set('alpha', 'beta'); >> > s.has('alpha'); // true >> > >> > I think this is a lot better than the verbosity that is >> > >> > var s = new Set(); >> > s.add('alpha'); >> > s.add('beta'); >> > >> > >> > Peter >> > _______________________________________________ >> > es-discuss mailing list >> > es-discuss@mozilla.org >> > https://mail.mozilla.org/listinfo/es-discuss >> >> _______________________________________________ >> es-discuss mailing list >> es-discuss@mozilla.org >> https://mail.mozilla.org/listinfo/es-discuss > > > _______________________________________________ > es-discuss mailing list > es-discuss@mozilla.org > https://mail.mozilla.org/listinfo/es-discuss > _______________________________________________ es-discuss mailing list es-discuss@mozilla.org https://mail.mozilla.org/listinfo/es-discuss
