On Sun, Jun 10, 2012 at 5:31 PM, Erik Arvidsson <erik.arvids...@gmail.com>wrote:

> On Sun, Jun 10, 2012 at 6:56 AM, Geoffrey Sneddon <gsned...@opera.com>
> wrote:
> > As such, I'm somewhat dubious as to whether we can actually change the
> > format that much without breaking sites. For reference, we support
> > Error.stack (supposedly identical to SpiderMonkey in format, though
> > obviously not) and Error.stacktrace (which is meant to actually be human
> > readable). Originally, we had Error.stacktrace as Error.stack, but it
> just
> > broke too much (we spoof UA on some Google sites by default, and have to
> > choose whether to go down IE/Fx/WK code-path, and often all three rely
> upon
> > non-standard behaviour).
> >
> > [1]:
> >
> http://code.google.com/p/google-web-toolkit/source/browse/releases/2.4/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
>
> This looks pretty broken to me as is. It does not seem to work correct
> for the V8 style formatting that is used by Chrome and IE.
>

Note that GWT uses deferred binding to substitute browser-specific
implementations for the version being compiled -- see
http://code.google.com/p/google-web-toolkit/source/browse/releases/2.4/user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml
where
the mappings are defined.  So, for Chrome, CollectorChrome is used instead
of Collector.

-- 
John A. Tamplin
Software Engineer (GWT), Google
_______________________________________________
es-discuss mailing list
es-discuss@mozilla.org
https://mail.mozilla.org/listinfo/es-discuss

Reply via email to