So, would it be fair to say that you've experienced the following, a few
times:
1. You were reading code, and it wasn't clear what the intent of the code
was
2. You found that the code had been changed, but it wasn't clear why the
new code was better/more appropriate than the old code
3. The commit message didn't contain enough information
4. The pull request didn't explain why the code change was made
5. There was no bug/issue to trace the change to, that could give context
If that's fair, then I would probably suggest looking at numbers 1, 2, and
3 as the best way to resolve this? Or is there another factor here?
Steve
On Thu, Mar 17, 2016 at 10:04 PM Kurtis Rader <kra...@skepticism.us> wrote:
> On Thu, Mar 17, 2016 at 12:54 AM, Stestagg <stest...@gmail.com> wrote:
>
>> I was under the impression that, on GitHub, pull requests are as easy to
>> discover as issues. Give this, I'm not sure I understand the benefit of
>> this restriction
>>
>
> It's hard enough to get people to search the open issues before opening a
> new issue. But that isn't really the motivation. What drove me to propose
> this was researching the reason for several changes and finding nothing but
> the original commit comment. And that commit comment was sorely lacking in
> terms of details such as the rationale for the change.
>
> Also, I want to make it really clear that this would not be a
> "restriction". I would never summarily reject someones non-trivial
> pull-request solely because it wasn't tied to an open issue. Because this
> is an open source project rather than internal to a company we cannot, and
> do not, want to impose that level of control. What I'm wondering is if
> others have been as frustrated as myself when trying to figure out why many
> changes are being made and if we can foster an environment that encourages
> a little more discussion before people go to the trouble of making a
> pull-request.
>
> --
> Kurtis Rader
> Caretaker of the exceptional canines Junior and Hank
>
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
_______________________________________________
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users
