On 03/17/2016 08:54 AM, Stestagg wrote: > I was under the impression that, on GitHub, pull requests are as easy to > discover as issues. Give this, I'm not sure I understand the benefit of > this restriction
On top of this pull requests also have a nice discussion page on github anyway from memory so its probably the best case for discussing submissions, having said that if the pull request is fixing a non trivial bug it might be good to have a ticket so it can be referenced in changelogs and release announcements especially if someone goes to the effort of making a script to pull out the closed tickets since last release. As an aside the companies I have worked for in the past have generally had separate processes for maintaining bug issues and code review, partly also because the process for new features is also a separate process normally driven by some kind of product management. Cheers Simon > > Steve > On Thu, 17 Mar 2016 at 05:22, Kurtis Rader <kra...@skepticism.us > <mailto:kra...@skepticism.us>> wrote: > > I don't want to make submitting bug fixes onerous. However, in my > professional experience (not open source) it seems to me most > pull-requests should be tied to an open issue so they're easier to > discover. That also provides an opportunity to discuss the issue > before we're presented with a pull-request. Obviously there are some > types of pull-requests, such as trivial fixes of typographical > errors or style cleanups or improvements to the documentation, that > don't need or benefit from an associated issue. So we shouldn't make > the association with an open issue a hard requirement. Too, unlike > projects internal to a company we can't reasonably expect all > contributors to the fish project to be aware of norms like tying > changes to open issues. > > My question is whether other contributors of changes have an > opinion? And if you're in agreement with me what's the best way to > encourage tying pull-requests to open issues? > > -- > Kurtis Rader > Caretaker of the exceptional canines Junior and Hank > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > > http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140_______________________________________________ > Fish-users mailing list > Fish-users@lists.sourceforge.net > <mailto:Fish-users@lists.sourceforge.net> > https://lists.sourceforge.net/lists/listinfo/fish-users > > > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 > > > > _______________________________________________ > Fish-users mailing list > Fish-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/fish-users > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Fish-users mailing list Fish-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/fish-users
