Norman Vine writes:

 > This might be a problem too
 > 
 >  time   seconds   seconds    calls  us/call  us/call     
 >  5.81      2.31     0.20  3455357     0.06     0.06  
 > FGGlobals::get_current_view(void) const
 > 
 > Judging by the number of times this is called 
 >  i.e  54 times per LOOP iteration 
 > this 'might' be a 'good' candidate for inlining

It's a bad one for inlining, actually, because that forces globals.hxx
to have a dependency on viewmgr.hxx, so all of FlightGear has to
rebuild whenever Jim touches the viewer code.

What we should do is find out why get_current_view is called so much
-- almost no other part of FlightGear should care about it.  Jim's
already started uncoupling things, and we can look to see if it's used
in a loop somewhere (where it could be assigned to a variable just
once).


All the best,


David

-- 
David Megginson
[EMAIL PROTECTED]


_______________________________________________
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel

Reply via email to