On 3/11/2016 3:16 PM, Jan Danielsson wrote:
On 11/03/16 23:49, Ross Berteig wrote:
[---]
* jan-manifest-tags
New feature to generate a file containing a list of the tags on the
current checkout for the benefit of build and release tooling, suggested
and mostly implemented by Jan Danielsson:
http://www.mail-archive.com/fossil-users%40lists.fossil-scm.org/msg22317.html
It seems to have proceeded well past proof-of-concept, then stalled.
The status on this is that it's more or less finished in the sense that:
- It can be used for what I originally set out to accomplish
(creates manifest.tags on request).
- manifest.tags is included when generating source archives.
- I haven't found any cases where the manifest.tags isn't updated as
intended (but it would be neat if others could take a look at it).
- It's non-intrusive (people who don't want to use the feature will
never notice the change).
It looks like a useful feature to me, I just don't currently have a need
for it. But given that one of the early settings I change in a larger
project is to turn the manifest on so that I can include the ID in
version strings, I can certainly see using this to distinguish test from
release builds.
I generally like the way you've arranged it to be invisible until
requested. That makes it really easy to recommend it be merged to trunk
sooner than later.
Perhaps I have forgotten something, but the remaining change I'd like
to do is per a request from Steve Stefanovich
(http://www.mail-archive.com/fossil-users%40lists.fossil-scm.org/msg22337.html).
Unfortunately I have been involved in a new project which has left me
with very limited time.
I'll try to find some time to finish this next weekend or so.
No pressure. I just set an arbitrary cut-off date to prevent myself from
reading the entire history of fossil, and your feature just barely
touched it.
It does look like something that ought to be in trunk. I'll see if I
can't add a test case for it to the test framework "soon". After that,
and possibly after a resolution to the current branch tweak request, we
should seriously consider merging.
One thing I can do right now is merge the current tip of trunk in to it,
and resolve any quirks that result from progress on trunk since January.
Since a big change has been improvements to the test framework, I'd want
to do that before building test cases anyway.
--
Ross Berteig r...@cheshireeng.com
Cheshire Engineering Corp. http://www.CheshireEng.com/
+1 626 303 1602
_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
