On Sat, Mar 12, 2016 at 2:27 AM, Ross Berteig <r...@cheshireeng.com> wrote:
> > > On 3/11/2016 3:40 PM, Joe Mistachkin wrote: > >> >> Ross Berteig wrote: >> >>> >>> >>> * [ff4a] pending-review >>> >>> IMHO, merge this. >>> >>> Changes how the fusefs command appears when fossil is compiled without >>> fusefs included. Seems reasonable. In fact, I wonder if the json command >>> shouldn't get a similar treatment when json is not enabled. >>> >>> >> It would be nice if we could be consistent in this area. If a feature is >> not included in the build, it should ideally be totally gone. >> > > I don't feel strongly about gone or not, but consistent would be good. > IIRC there was some resistance to the original version of this change where > it was totally gone, and the current state where fusefs became a secondary > command that fails was the result of that. https://www.mail-archive.com/fossil-dev%40mailinglists.sqlite.org/msg00374.html [snip] >>> * baruch_timeline_fixes >>> >>> Builds on Windows. A quick scan of the source changes doesn't look like >>> trouble. /timeline and its buttons seem to work, but I haven't located a >>> test case to evaluate this change. >>> >>> >> There is a test case somewhere. I think it may have been posted to the >> mailing list(s) at some point. I don't quite know enough about that code >> to be 100% confident in the changes. >> >> > I thought I remembered some discussion, but my google-fu is failing me > today. The obvious test of just loading /timeline in fossil ui and clicking > older and newer worked. I didn't poke at it much more than that. https://www.mail-archive.com/fossil-dev%40mailinglists.sqlite.org/msg00419.html -- ˙uʍop-ǝpısdn sı ɹoʇıuoɯ ɹnoʎ 'sıɥʇ pɐǝɹ uɐɔ noʎ ɟı
_______________________________________________ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
