On Wed, Oct 16, 2013 at 4:33 PM, <sky5w...@gmail.com> wrote: > When I stumbled on this '#' comment character commit issue, I was inclined > to ask why that was chosen? I actually lost a '#define blah blah' comment I > wanted to highlight. > Can the comment character be user selectable at this late stage? > I would prefer comments lead with ! or ' or ; or // or /* or ;=. >
Considering the relatively harmless effect of losing an unusual (though admittedly valid) commit message (which can be edited afterwards), and the long-standing conventions surrounding the current convention (cvs, svn, git, etc.), i won't volunteer to make that change ;). But maybe someone else will. Making something (anything) configurable always adds a relatively high amount of overhead compared to hard-coding it, and this particular case would bring a great deal more (relatively speaking) than many cases because we'd be replacing a single hard-coded '#' with the logic to store, load, validate (that it's exactly 1 ASCII byte), and compare the character (and then hope someone doesn't set it to a newline or some such). As soon as it's configurable, someone would want some Cyrillic or Arabic character as the marker (and then they'd want RTL[1] support for the Arabic version)... it all leads down dark, scary, paths riddled with corner cases just for the sake of a harmless one-time loss of a commit message (which can then be edited to fix it). There are other use cases where '#' is useful, e.g. Google Code uses #XXXX to refer to/detect ticket numbers, but fossil has always used [uuid] for that. [1] right-to-left, http://en.wikipedia.org/wiki/Right-to-left -- ----- stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal "Since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do." -- Bigby Wolf
_______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
