On Feb 5, 2009, at 9:29 PM, Andreas Zeidler wrote:
[...snip...]yes, that works. in any case this should be documented, though. [...snip again...]Perhaps z3c.autoinclude could check if `os.environ.has_key('Z3C_AUTOINCLUDE_DISABLED')` and the test runner and/or a buildout option could set that environment variable?yep, also +1. after all, that's exactly what environment variable are for, aren't they? :)
i forgot to mention that it'd be great if you could try to work these out until some time next week. technically the revision deadline is this saturday, of course, but since my review was several days late, i think it's only fair to still grant you a full week to address these issues. i hope the delay doesn't cause too many inconveniences and you'll find the time it takes...
cheers, andi
-- zeidler it consulting - http://zitc.de/ - i...@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.2rc1 released! -- http://plone.org/products/plone/
PGP.sig
Description: This is a digitally signed message part
_______________________________________________ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
