On 14-01-16 03:53 AM, Michael T. Pope wrote:
> On Thu, 16 Jan 2014 19:38:17 +1030
> "Michael T. Pope" <mp...@computer.org> wrote:
>> All I can think
>> of is there is some attempt to place popups in a layer that should be
>> always in front of the map layer, but this happens at the point they are
>> created and is never changed.
>
> This has been cleaned up.  Every component that ever gets explicitly
> placed on the FreeCol canvas is assigned one of the JLayeredPane
> predefined layers.  AFAICT there is no way to even specify "behind".
> Suggestions of what more we can do here would be most welcome.

Yeah, I thought the behind bit was odd, too. I wonder if it has 
something to do with how the full screen window flags itself to the 
operating system rather than with the popups themselves. It seems odd 
that the placement works properly for windowed mode but not full screen 
mode. I also noticed that the dialogue does get the focus and it is 
possible to operate it blind if you know the contents of it.

Personally, I don't usually use full screen mode. I only noticed this 
when I forgot to specified "--windowed" when starting the game.

Given this particular weirdness, and others that seem to happen only in 
full screen mode, would it make sense to default to windowed mode 
instead of full screen mode? Windowed mode does correctly determine the 
full size of my display so the only difference is the real estate lost 
to the window decorations and the task bar.

>>> Perhaps it's only checking for the top left coordinates when
>>> selecting a position?
>>
>> I hope so.  I will look at it.
>
> Kicked it in git.3948a84.  Looks better to me.

Yes, looks better to me, too. The smaller windows still appeared to the 
side of the Europe window (and were fully visible) but the much larger 
"train" window showed overtop instead of 95% hidden. I think in this 
case, it is best to err on the side of having the windows fully visible 
rather than avoiding overlapping, simply from a usability standpoint, 
especially for the newcomers to the game. I suspect having the windows 
show fully will cause less problems overall than having them 
substantially hidden when they don't fit.

This also substantially improves usability on smaller windows 
(1280x1024ish and smaller) where I have a recollection of popups 
appearing totally outside of the visible window area. That seems to be 
fixed also with this tweak.


------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to