On Fri, 31 Jul 2015 19:22:22 +0200 win...@genial.ms wrote: > > Related to this I have just put in the fix for the second race in BR#2867, > > which simplifies the InfoPanel in MOVE_UNITS_MODE (git.1728101). This has > > probably caused more cases of a blank InfoPanel, which will need fixing as > > they are understood. > > When I saw the diff I suddenly had the idea what the reason for BR#2806 is. > It must be the InfoPanel not knowing about the next active unit. > I pushed a tentative fix, but I could not do checking for how it influences > BR#2867. Could you do that?
I think you have just reinstalled the possibly racy code with the call to hasNextActiveUnit:-P. BR#2806 is due to the InfoPanel not knowing about the *current active unit*. What needs to happen is to find where it fails to get updated. It must be a (rare) action, probably in IGC where we fail to call updateActiveUnit. I have been on the look out for it in my play testing, but do not recall seeing it lately. It may even be fixed. However, what *is* broken is the terrain mode. AFAICT, "Toggle View Mode" is not working. BTW, do not be alarmed if there are heaps of semi-pointless messages coming out of the IR tracker. There are a lot of requests there with no assigned "Milestone" (not to mention quite a few that are fixed or implemented, and some that need to die). I am going through and fixing this so that they show up as "Accepted", usually by making a trivial change to priority. Cheers, Mike Pope
pgp2Ik3DIk5eP.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
