Hi, > Gesendet: Samstag, 01. August 2015 um 12:57 Uhr > Von: "Michael T. Pope" <mp...@computer.org> > An: "FreeCol Developers" <freecol-developers@lists.sourceforge.net> > Betreff: Re: [Freecol-developers] 0.11.4 > > On Fri, 31 Jul 2015 19:22:22 +0200 > win...@genial.ms wrote: > > When I saw the diff I suddenly had the idea what the reason for BR#2806 is. > > It must be the InfoPanel not knowing about the next active unit. > > I pushed a tentative fix, but I could not do checking for how it influences > > BR#2867. Could you do that? > > I think you have just reinstalled the possibly racy code with the call > to hasNextActiveUnit:-P. >
Sorry :P Btw., I was not happy how your fix did hide the appearance of BR#2806, as it would just wrongly display the end of turn message instead of the empty state, when there might still be activatable units left. We need to find a better solution. What we are currently having is manual updates and copying around of that information to multiple classes (some model class, MapViewer, InfoPanel, ...), which can easily get out of sync, if a single copy is not made somewhere, and adds much tedious busywork when coding. Generally, I would prefer there be a central place containing the definitive answer to which unit is activated at that time. That place should be polled by all other methods in need of the information, at the time of immediate need. I'm not sure if its better keep it in a model class or, as this need not be saved, some new gui-state class, but both is better than manual copy/update at state change. > However, what *is* broken is the terrain mode. AFAICT, "Toggle View Mode" > is not working. For me it was always working when I used it. We should just cut down on automatically toggling that state and just keep it as set by the user. > BTW, do not be alarmed if there are heaps of semi-pointless messages > coming out of the IR tracker. There are a lot of requests there with no > assigned "Milestone" (not to mention quite a few that are fixed or > implemented, and some that need to die). I am going through and fixing > this so that they show up as "Accepted", usually by making a trivial > change to priority. I'm actually happy you took the time now to reprioritise these, I sometimes tried to update a few but had not enough information to change most and did not want to spam all of them asking if they needed an update. But I read in the developer docs the accepted setting should be reserved only for items where the dev team is committing to implement them _for the next release_. I actually find that easier, too, as then there is a smaller amount of tracker items to pay immediate attention to, without 100 other items also being accepted, although its uncertain when/if any work will be done on them. Is it worth looking at the Ideas for FreeCol2 tracker, if something with an earlier usefulness is buried there? Btw., is the stuff in the restructuring tracker relevant anymore? What is actually the purpose of that tracker, announcing refactorings? Do we need it at all? Do we need the support tracker? Caleb and me closed the few ancient items, which had been there, so its empty now. People mostly just write a BR or, if uncertain, ask in the forum. Wouldn't it be better to have a separate tracker for Missing Artwork and other things related to that? The ancient opening mail in the graphics list promised such a tracker and people with artistic skills would probably not see such requests when they are buried inbetween a hundred bug reports. In an earlier mail you said you feel tags are unnecessary, but now I actually can not see easily which commit, if any, is containing exactly the same code as in the downloadable files, as I remember you wanted to backport some bugfix (but noone will remember that later). Branches are nice for development, but tags are useful for marking a fixed release, such that people can clone, then git tag --list, then choose a tag to easily type it in the checkout command, to get a release commit. Oh and I tried out the installer from the download section. First I was irritated I did not see the option to create a desktop shortcut, but on second try it did show up, so it might have been just a too fast click being registered twice. I can say it worked as good as the ones I compiled when trying it out earlier. Greetings, wintertime ------------------------------------------------------------------------------ _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
