Kevin Lawton wrote:
>
> Ramon van Handel wrote:
> >
> > Once again, it looks great !!! Nice base for further coding.
> > Only, C++ comments are so ugly :) (never mind, I'm a bit
> > weird ;)).
>
> I like C++ comments because they're less intrusive and you don't
> have to worry about where the end of the comment is. I used
> to hate them, then I converted.
Hmm, okay. Well, I'll try to remember to use them too then.
> > Do you mind if I go through your code and clean it up a bit ?
> > By that I mean putting #defines in header files, and adding
> > large amounts of documentation where your code is a bit cryptic.
> > Better have documentation right from the start, and hey,
> > there's no better way to learn how a piece of code works than
> > trying to document it (except, of course, writing it yourself :))
>
> Hey go nuts. You are head man in charge of cleaning up
> and commenting the code. If you want any help with comments,
> let me know.
Hehe :) I understood all of the code, I just think it can use
more comments :). That's important for when the code gets
more complicated, because then it'll not be so easy anymore
to figure it all out from scratch.
> Other things on the todo list are:
>
> Making sure multiple user processes can't access the
> kernel module at one time (for now), except a mechanism
> to reset the module driver use count in case we mess up
> and want to rmmod it. I have the user/resetmod.c program
> for this, but there may be a better way.
If this is just for initial alpha releases, why bother ?
OTOH, this shouldn't be hard to implement :)
> > Also, I don't want to whine too much about this but I think
> > that we need to make some kind of arrangement about coding style
> > (nothing fixed, just general guidelines --- that's always useful
> > if multiple people need to work on the same piece of code.) On
> > my wishlist are bigger tabstops than Kevin uses, and to get rid
> > of C++-style comments (but that's probably not going to be ;))
>
> I'm up for some suggested guidelines. It might make things go
> more smoothly. Keep in mind though this is code by anarchy, so
> we shouldn't push any hard rules.
Yes, that's what I meant.
Well, what I'd like to see is either using a few spaces (at least
four) for indents, or otherwise a tab. That makes it a lot
easier to read.
Ramon
