Ramon van Handel <[EMAIL PROTECTED]> wrote:
> PS, we all have very different coding styles... during my
> previous cleanup I ran GNU indent over several
> files (including user.c) with the following options:
>
> -bad -bap -bli0 -nce -sc -di6 -nbc -lp -i4
>
> The results were more or less pleasing (to me, anyway ;)).
> If nobody objects, I'll keep doing this once in a while; it'll
> keep the code cleaner. Unfortunately, indent doesn't appear
> to support C++ :-/
Two points:
- Please don't reformat the code originating from Bochs; IMO it's
much more important to keep clean diffs between the FMW and the
Bochs versions so as to simplify back-and-forth porting of bug
fixes and the like, than it is to enforce a common style.
- If you want to reformat the FMW code itself, please don't mix up
format changes with real modifications or new code. Keeping useful
CVS diffs is very important; while a diff clearly marked as 'reformat
only' can be completely ignored, a diff that contains two lines of
crucial semantical change amidst thousands of lines of whitespace-only
diffs is evil ;-)
[ In fact, there's probably no point for you to send me a patch
containing only the results of an 'indent' run; I'd suggest we
agree on a set of indent options and I run it myself on my main
tree ... ]
Bye,
Ulrich
