Ulrich Weigand wrote:

> Two points:
> 
>  - Please don't reformat the code originating from Bochs; IMO it's
>    much more important to keep clean diffs between the FMW and the
>    Bochs versions so as to simplify back-and-forth porting of bug
>    fixes and the like, than it is to enforce a common style.
> 
>  - If you want to reformat the FMW code itself, please don't mix up
>    format changes with real modifications or new code.  Keeping useful
>    CVS diffs is very important; while a diff clearly marked as 'reformat
>    only' can be completely ignored, a diff that contains two lines of
>    crucial semantical change amidst thousands of lines of whitespace-only
>    diffs is evil ;-)
> 
>    [ In fact, there's probably no point for you to send me a patch
>      containing only the results of an 'indent' run; I'd suggest we
>      agree on a set of indent options and I run it myself on my main
>      tree ... ]

Strongly agreed.  If anyone's a real style freak, write more code
than every else.  Then the majority of the code will be in your
liking.

-Kevin

Reply via email to