I got it! It's a bug in the X11 client that occurs if the preferredBitsPerPixel option changes during the deactivation-reactivation sequence. Upon the first successful connection the server sets preferredBitsPerPixel to 32, and the client saves this value in xf_post_connect (xfi->srcBpp = instance->settings->color_depth). But during the deactivation-reactivation sequence the server sends preferredBitsPerPixel=16, but the value in xfi is not updated. Thus, color conversion in xf_Bitmap_New is broken, because srcBpp is assumed to be 32, but it should be 16.
Using this line data = freerdp_image_convert(bitmap->data, NULL, bitmap->width, bitmap->height, bitmap->bpp, xfi->bpp, xfi->clrconv); instead of this data = freerdp_image_convert(bitmap->data, NULL, bitmap->width, bitmap->height, xfi->srcBpp, xfi->bpp, xfi->clrconv); results in the expected bitmap output. So the question is: should we fix this by ... 1) using the line above, or 2) updating xfi->srcBpp during reactivation (is it ok to just change it on the fly?), or 3) doing both of the above? Cheers, Lysann On Jul 23, 2012, at 8:18 AM, nikhil wrote: > Yes you are right, graphics is badly distorted. > I captured few packets to look in to them. After 3-way handshaking, the first > packet that is sent from client looks good. > At least it's format is exactly the same as they have pointed out in the open > specification. > But the packet that is sent after this one is different when compared with the > one that is sent from the windows client. > > any ideas on this? > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Freerdp-devel mailing list > Freerdp-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/freerdp-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freerdp-devel mailing list Freerdp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel
