Hi Dirk! On Mon, Jan 08, 2007 at 08:59:12AM +0100, Dirk Nehring wrote: > On Sun, Jan 07, 2007 at 07:32:37PM +0000, Thorsten Glaser wrote: > > Dirk Nehring dixit: > > > > >Since you are not documenting any patches, I suggest our old style > > >patch format (xxx-<meaning of patch>.patch) > > > > 1. Forget it. > > 2. Let n0-1 do what he decides is best. We agreed that the > > package/subsystem maintainer decides, and that for small > > patches, the BSD style is better, and for kernel and busybox, > > the OpenWrt style is better. > > 3. "Since you are not documenting" is not a reason to switch, > > because the OpenWrt patch format isn't better without > > documentation either. Rather the contrary. > > I am very sorry for you that you are so tenacious in your opinion. The > common style (not: OpenWRT style) is better in 2 ways than patching file > by file:
Well, it doesn't matter how to call the way asterisk was patched before. It wasn't documented. If it had been, I would have spend some time verifying whether each is needed or not. > * patches are grouped together in one file when they belongs together > (as in Asterisk's case) What did we say is update-patches worth for? Do you think I don't remember my own words? > * patches have a short description in their filename. This is often very > helpful. Yes, and the old patches were named about as good as update-patches does name them. Well, besides you being able to compile asterisk versions other than the one we use without heavy patching, the current one didn't compile without it. If you had spend a minute reading the patches, you would have seen that about 90% of them only fix the include statement for integrating the db.h shipped by the package. Also I suggest you reread my initial mail to this list to get an idea about what I am doing in this position. But I will recall the important part for you: it's me who will be working at asterisk for the next month (or two if necessary) and you can bet your bottom dollar on me doing good work at it. If you think I randomly change stuff, your wrong either. Just check the corresponding commit message and you will see I even mentioned there that I got wbx's support in doing it. One last thing to calm you down: if in march you still think asterisk integration is crappy, you get my full approval right now to revert everything and start over with version 1.2.1 again. Regards, Phil
pgp5o2M2cl1l0.pgp
Description: PGP signature
_______________________________________________ freewrt-developers mailing list [email protected] https://www.freewrt.org/lists/listinfo/freewrt-developers
