On Mon, Jan 08, 2007 at 11:58:37AM +0100, Phil Sutter wrote: > Hi Dirk! Hi Phil,
> > * patches have a short description in their filename. This is often very > > helpful. > > Yes, and the old patches were named about as good as update-patches does > name them. Here I do not agree with you. > > Well, besides you being able to compile asterisk versions other than the > one we use without heavy patching, the current one didn't compile > without it. If you had spend a minute reading the patches, you would > have seen that about 90% of them only fix the include statement for > integrating the db.h shipped by the package. To give an example, if you would be easier for my limited mind to understand if there is only one patch, like 110-fix-db-includepath.patch which includes all (20 or 30) oneliners of your fix. This is more clearly and helpful for everyone. Just recall nbd's mail from 01 Dec 2006: [...] I don't know about those developers of FreeWRT that mentioned concerns about this patch structure, but for me the benefits would never outweigh the costs, since I'm totally used to having all the information on which patch is intended to do what readily available. For me the overhead of making properly structured patches is neglegible... [...] > Also I suggest you reread my initial mail to this list to get an idea > about what I am doing in this position. But I will recall the important > part for you: it's me who will be working at asterisk for the next month > (or two if necessary) and you can bet your bottom dollar on me doing > good work at it. > > If you think I randomly change stuff, your wrong either. Just check the > corresponding commit message and you will see I even mentioned there > that I got wbx's support in doing it. Phil, I'm sorry that you get the impression that I am displeased with your work. The discussion is only about patching techniques, nothing more. I am very confident that your work is and will be a big improvement for FreeWRT. Keep up the good work! I will not carry on the discussion anymore, everyone will probably do it's best for the project. Dirk _______________________________________________ freewrt-developers mailing list [email protected] https://www.freewrt.org/lists/listinfo/freewrt-developers
