On 19 May 2003 08:52:23 +0200, Dominik Vogt wrote:
>
> On Mon, May 19, 2003 at 03:01:38AM +0200, Olivier Chapuis wrote:
> > Hello,
> >
> > Attached to this msg 2 new cmds StyleById and DestroyStyleById.
> > StyleById applies styles to specific windows:
> >
> > Pick Style $[w.id] NoTitle, !Borders
> >
> > DestroyStyleById can destroy such a style.
> >
> > The implementation solve the pbs with the patch send by Craig Milo Rogers
> > a few weeks ago:
> > - When a window is "destroyed" the associated StyleById is destroyed
> > too (if not a new window can have the same id and the old style by
> > id is applied).
> > - No more ambiguity with the Style cmd as we have a new cmd.
> >
> > I see no strong reason against this patch, but (as we are under
> > feature freeze) a vote against it. Any one?
>
> Adding the patch to 2.5.x is out of the question (feature freeze).
> Apart from that, this topic requires much more thought. We don't
> want to make an ad-hoc syntax now, find out later that it does not
> work with all the other Style related enhancements and the
> redesign exevrything from scratch.
I would like to see WindowStyle and DestroyWindowStyle in 2.6.x as
implemented in the patch, it makes many things clean and possible.
Either it is called new or old, it's a good feature. Can you argue that:
* We all (users/developers) dreamed about window specific Style.
* The patch in the question is not problematic (you may verify it).
* We already discussed WindowStyle and decided (including Dominik) that
this is the right thing to do. It even (together with StyleFunction)
may eventually replace Style as we know it now. Having WindowStyle
that works on window context is good regardless of whether we have
Style or StyleFunction.
* Style by id (works on one existing window) and Style by name (works
on many existing and non-existing windows) should not be mixed, i.e.
it should be 2 different commands with the first having a preference.
* In the future all individual window states may be mixed with
individual window styles, i.e. "Stick" is just "WindowStyle Sticky",
but this is for the future. Currently we just need WindowStyle
as defined by the posted patch (with the command name changed).
To see WindowStyle is not really a new suggestion, here is a thread:
http://www.hpc.uh.edu/fvwm/archive/0112/msg00226.html
(all "WindowId $0" tips should be read as "ThisWindow" in the thread.)
Again, the whole implementation of this is for the future, adding
WindowStyle now is only a small and safe step in this direction.
Even if in the future some internals may be changed the syntax is not.
Regards,
Mikhael.
--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
