On 2023/8/24 18:20, Robin Dapp wrote:

Yes, it's better to call it one_quad.

I'd suggest to go with quarter as before or quarter_width_op
or something.

OK for quarter.


Is this necessary for recognizing a different pattern?

Are you saying that the testcases xxx-1 and xxx-2 are duplicated? If
so, I have no problem removing it and just keeping xxx-1 testcase
since it is still possible to cover my code.

I was just curious why the NEW_TYPE bi = b[i] was necessary instead
of using b[i] directly.

Oh, I think there is no difference between the two because the type of b is NEW_TYPE. So it's okay to remove this statement.

--
Best,
Lehua

Reply via email to