On Thu, Apr 23, 2020 at 09:33:47AM -0600, Jeff Law wrote:
> On Thu, 2020-04-23 at 06:46 -0500, Segher Boessenkool wrote:
> > Hi!
> > 
> > On Thu, Apr 23, 2020 at 12:54:04AM +0000, Tamar Christina wrote:
> > > but trains for GCC Will likely be very short because of Changelog 
> > > conflicts.
> > 
> > Why that?  Your patches should *not* touch changelog files, ever.
> > 
> > For CI it is probably easiest if the CI never gets to see the changelog
> > at all, and that isn't hard to do ;-)
> *Nothing* should touch changelog files :-)  They should be generated from the
> VCS.  IMHO of course.

My point was that this should *never* be part of patches, already.

> That implies that the patch includes a proper ChangeLog entry in the commit
> message.  It also implies that if we muck one up, then we live with it rather
> than going back and rewriting them.

There also is the middle ground where we still have changelog files, but
normal checkins automatically update those from the commit message.
This is an intermediate step, but also makes it possible (and even easy)
to fix up mistakes.


Segher

Reply via email to