Hi Peter, Peter Clifton writes: > [...] > Their scope is far wider than ever implied by the topic at hand, and > unfortunately impacts a great deal of the noscreen changes I've been > working on. As far as I can tell (without spending a day or so looking), > it would be incompatible with most of the tried and tested work on > glist-dev. > > The intent of the patches look good, refactoring stuff which should be > in libgeda out of gschem, re-writing functions to tidy them up, however > many of these functions are key to the noscreen changes. Where they > needed re-writing, or grouping together, (as part of the noscreen > changes), I did that. > > I have also (separatly in git) made use of cached world bounds (instead > of screen bounds), to speed up hit detection, moved bounds recalculation > of bounds out of the ..._get_bounds() functions, and into > the ..._recalc() functions.
I have played with the patches you posted. And while I failed to apply them to the glist_dev branch, I think there is not much problems between your changes and mines. The most visible (and probably the biggest) is the changes to the get_bounds_* functions to take an OBJECT instead of a LINE, ARC. Apart from that it will be no big deal to merge. I think the mistake is to have based your changes on glist_dev and not HEAD: correct me if I am wrong but it had nothing that specifically require changes from glist_dev and as such should have been part of an independent branch. Anyway I will start merging your changes to my refactoring of translate and get_bounds function (the action stuff is not concerned) and let you know how it really works. > [...] > On 23rd Nov, I emailed the list to say I was looking into noscreen > changes. I appreciate Patrick, your changes will have taken some time, > and may even predate me starting the noscreen experiment, but it ought > to have been obvious that we were both working in the same area from my > emails. There have been emails discussing branching for some development > work in this area, (and I've been waiting for glist-dev to merge for > that). > > If you'd mentioned what your work covered, I would not have put so much > time and effort into my own. (Instead waiting to start from a cleaner > code-base). I don't see any email indicating your work until 6th Dec. See my answer to Carlos for a timeline of the events. > [...] > The noscreen work / experiment I've done, I think has some useful code. > Not all of it is purely noscreen related, however it the later (less > noscreen related changes) are all separate, and very small commits, and > are made possible / sensible / necessary by the noscreen changes. > > Collectively, they simplify the codebase significantly. It isn't > complete yet, but I think represents a cleaner platform to start future > refactoring work. On this particular point please ask Peter TB Brett to forward you my answer to his first private message on this matter. Regards, Patrick _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
