I made the requested changes, and I've maintained the code and it works ok with the current repo. However, I didn't receive any other feedback, and didn't get the requisite two ship its.
Cheers, Anthony Gutierrez http://web.eecs.umich.edu/~atgutier On Mon, Jan 5, 2015 at 6:27 PM, Andreas Hansson <andreas.hans...@arm.com> wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2305/ > > On July 28th, 2014, 12:38 a.m. UTC, *Andreas Hansson* wrote: > > Ship It! > > What is the state of this? > > > - Andreas > > On July 24th, 2014, 7:44 p.m. UTC, Anthony Gutierrez wrote: > Review request for Default. > By Anthony Gutierrez. > > *Updated July 24, 2014, 7:44 p.m.* > *Repository: * gem5 > Description > > Changeset 10259:eb23219d83a4 > --------------------------- > dev: add an ethernet switch model > > this patch adds a very simple ethernet switch model. the basic design > behind the switch is to modularize the interface, fabric, and overall > switch model as much as possible. The switch model: > > 1) buffers incoming/outgoing packets in the ports > 2) utilizes Links from EtherLink as the point-to-point connections > in the switch fabric > 3) uses a simple least-recently-granted arbitration policy to forward packets, > and doesn't provide any support for things like flow control. it also does > not provide any features outside the link layer, which some switches may > support e.g., ARP, filtering, etc. > * * * > junk > > Testing > > Successfully ran 3 systems with 1 memcached server and 2 memcached clients > simultaneously issuing requests. > > Diffs > > - src/dev/Ethernet.py (23384aa97d8533f6e3f812d015dccaab3c0267af) > - src/dev/SConscript (23384aa97d8533f6e3f812d015dccaab3c0267af) > - src/dev/etherint.hh (23384aa97d8533f6e3f812d015dccaab3c0267af) > - src/dev/etherlink.hh (23384aa97d8533f6e3f812d015dccaab3c0267af) > - src/dev/etherlink.cc (23384aa97d8533f6e3f812d015dccaab3c0267af) > - src/dev/etherswitch.hh (PRE-CREATION) > - src/dev/etherswitch.cc (PRE-CREATION) > > View Diff <http://reviews.gem5.org/r/2305/diff/> > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
