----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5737 -----------------------------------------------------------
src/dev/etherint.hh <http://reviews.gem5.org/r/2305/#comment5101> I don't understand why this needs to be virtual... I mean, I see that you override it on EtherSwitch::Interface, but part of the idea behind these port objects is that you only pay for the virtual function dispatch once. I'm not sure why this broke down here, but I'd like to figure that out before we commit this code. - Steve Reinhardt On July 24, 2014, 12:44 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2305/ > ----------------------------------------------------------- > > (Updated July 24, 2014, 12:44 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10259:eb23219d83a4 > --------------------------- > dev: add an ethernet switch model > > this patch adds a very simple ethernet switch model. the basic design > behind the switch is to modularize the interface, fabric, and overall > switch model as much as possible. The switch model: > > 1) buffers incoming/outgoing packets in the ports > 2) utilizes Links from EtherLink as the point-to-point connections > in the switch fabric > 3) uses a simple least-recently-granted arbitration policy to forward packets, > and doesn't provide any support for things like flow control. it also does > not provide any features outside the link layer, which some switches may > support e.g., ARP, filtering, etc. > * * * > junk > > > Diffs > ----- > > src/dev/Ethernet.py 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/SConscript 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherint.hh 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherlink.hh 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherlink.cc 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherswitch.hh PRE-CREATION > src/dev/etherswitch.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2305/diff/ > > > Testing > ------- > > Successfully ran 3 systems with 1 memcached server and 2 memcached clients > simultaneously issuing requests. > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
