> On July 22, 2014, 10:12 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.cc, line 55 > > <http://reviews.gem5.org/r/2305/diff/2/?file=40411#file40411line55> > > > > Not sure what the style guide says about the spacing here, but I've > > been using > > > > for (auto i: list) > > > > Does anyone have a strong opinion?
Style guide doesn't mention anything about colons except when they appear with labels. In current code there is never a space if it appears at the end of a label or as part of the scope operator. Only other place colons are used are as part of initialization lists, and in that case there is always a space. I don't have a strong opinion, but I typically associate a colon with a label, and just to differentiate I like to put the space. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5223 ----------------------------------------------------------- On July 22, 2014, 6:36 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2305/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:36 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10259:2d25a9f9969a > --------------------------- > dev: add an ethernet switch model > > this patch adds a very simple ethernet switch model. the basic design > behind the switch is to modularize the interface, fabric, and overall > switch model as much as possible. The switch model: > > 1) buffers incoming/outgoing packets in the ports > 2) utilizes Links from EtherLink as the point-to-point connections > in the switch fabric > 3) uses a simple least-recently-granted arbitration policy to forward packets, > and doesn't provide any support for things like flow control. it also does > not provide any features outside the link layer, which some switches may > support e.g., ARP, filtering, etc. > > > Diffs > ----- > > src/dev/Ethernet.py 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/SConscript 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherint.hh 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherlink.hh 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherlink.cc 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherswitch.hh PRE-CREATION > src/dev/etherswitch.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2305/diff/ > > > Testing > ------- > > Successfully ran 3 systems with 1 memcached server and 2 memcached clients > simultaneously issuing requests. > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
