----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3465/#review8336 -----------------------------------------------------------
src/dev/net/etherswitch.hh (line 108) <http://reviews.gem5.org/r/3465/#comment7228> all these members could be const? src/dev/net/etherswitch.hh (line 147) <http://reviews.gem5.org/r/3465/#comment7230> unsigned? if not it really needs a comment src/dev/net/etherswitch.hh (line 150) <http://reviews.gem5.org/r/3465/#comment7229> == it is unsigned src/dev/net/etherswitch.cc (line 93) <http://reviews.gem5.org/r/3465/#comment7231> should this perhaps even be a warn (or do we ever expect this to happen in a correct setup? src/dev/net/etherswitch.cc (line 113) <http://reviews.gem5.org/r/3465/#comment7232> could you add an assert here that size >= packet->length? src/dev/net/etherswitch.cc (line 176) <http://reviews.gem5.org/r/3465/#comment7233> all reschedule instead? src/dev/net/etherswitch.cc (line 339) <http://reviews.gem5.org/r/3465/#comment7234> Does this break checkpoint compatibility? If so that needs to be addressed. - Andreas Hansson On May 23, 2016, 8:08 p.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3465/ > ----------------------------------------------------------- > > (Updated May 23, 2016, 8:08 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11472:d4fada3b46ac > --------------------------- > dist, dev: Fixed the packet ordering in etherswitch > This patch fixes the order that packets gets pushed into the output fifo > of etherswitch. If two packets arrive at the same tick to the etherswitch, > we sort and push them based on their source port id. > In dist-gem5 simulations, if there is no ordering inforced while two > packets arrive at the same tick, it can lead to non-deterministic simulations > > > Diffs > ----- > > src/dev/net/etherswitch.hh 954d3014f7f0 > src/dev/net/etherswitch.cc 954d3014f7f0 > > Diff: http://reviews.gem5.org/r/3465/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
