On Wed, Oct 14, 2009 at 5:10 PM, nathan binkert <n...@binkert.org> wrote:
>> +    reschedule(tickEvent, curTick + tickEvent.when());
>
> This seems pretty suspect to me.  Generally, when we unserialize
> events, we first serialize the event time and then schedule it later.
> In fact, the way that the existing event reschedule is happening is
> likely not correct since it will cause a hiccup in the interval.
> Check out how ns_gige.cc serializes transmitTick and replicate it for
> both event and tickEvent this will ensure that the events are
> serialized and unserialized properly.

I see you did this:

    Tick transmitTick = txEvent.scheduled() ? txEvent.when() - curTick : 0;
    SERIALIZE_SCALAR(transmitTick);

Any reason not to serialize txEvent.when() directly?  That's what we
were planning to do.

Steve
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to