> On 2010-06-28 17:41:44, Nathan Binkert wrote: > > src/python/m5/SimObject.py, line 767 > > <http://reviews.m5sim.org/r/27/diff/2/?file=615#file615line767> > > > > I wonder if Children doesn't quite describe it right since children > > doesn't obviously imply recursion. iterDescendants? (I don't have strong > > feelings here.) > > Steve Reinhardt wrote: > I don't disagree, but don't have a lot of great alternatives. > iterDescendants is too long. iterTree? > > Steve Reinhardt wrote: > iterAll is my current favorite...
could just do descendants(). You could even go overboard and make it an @property, just so you could say "for obj in root.descendants: obj.foo()". Actually, I kinda like that. - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/#review53 ----------------------------------------------------------- On 2010-07-29 21:42:28, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/27/ > ----------------------------------------------------------- > > (Updated 2010-07-29 21:42:28) > > > Review request for Default. > > > Summary > ------- > > sim: move iterating over SimObjects into Python. > > > Diffs > ----- > > src/python/m5/SimObject.py b28e7286990c > src/python/m5/core.py b28e7286990c > src/python/m5/simulate.py b28e7286990c > src/python/m5/stats.py b28e7286990c > src/python/swig/core.i b28e7286990c > src/python/swig/pyobject.hh b28e7286990c > src/python/swig/sim_object.i b28e7286990c > src/sim/sim_object.hh b28e7286990c > src/sim/sim_object.cc b28e7286990c > > Diff: http://reviews.m5sim.org/r/27/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
