-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/27/#review132
-----------------------------------------------------------
I tried unproxying without sorting and the regressions passed, so it looks like
you were right that it's unnecessary. I then got rid of iterSortedChildren()
and replaced the one remaining use with
for obj in sorted(root.iterChildren(), key=lambda o: o.path()):
obj.print_ini(ini_file)
I can upload a new diff if you want but it seemed like overkill.
As far as the naming, I guess iterChildren has kind of grown on me; the
@property thing does seem like going overboard, but calling it descendants()
might not be too bad. How much benefit is there in having 'iter' in there so
you know it's an iterator? I'd be interested in having people other than Nate
weigh in on this, since while I consider his opinions valuable, his perspective
is not necessarily typical ;-).
- Steve
On 2010-07-29 21:42:28, Steve Reinhardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/27/
> -----------------------------------------------------------
>
> (Updated 2010-07-29 21:42:28)
>
>
> Review request for Default.
>
>
> Summary
> -------
>
> sim: move iterating over SimObjects into Python.
>
>
> Diffs
> -----
>
> src/python/m5/SimObject.py b28e7286990c
> src/python/m5/core.py b28e7286990c
> src/python/m5/simulate.py b28e7286990c
> src/python/m5/stats.py b28e7286990c
> src/python/swig/core.i b28e7286990c
> src/python/swig/pyobject.hh b28e7286990c
> src/python/swig/sim_object.i b28e7286990c
> src/sim/sim_object.hh b28e7286990c
> src/sim/sim_object.cc b28e7286990c
>
> Diff: http://reviews.m5sim.org/r/27/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve
>
>
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
