----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/342/#review522 -----------------------------------------------------------
You're commit message isn't formatted properly. src/cpu/o3/iew_impl.hh <http://reviews.m5sim.org/r/342/#comment775> Why not just not return a fault in these cases? - Gabe On 2010-12-06 16:12:26, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/342/ > ----------------------------------------------------------- > > (Updated 2010-12-06 16:12:26) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > O3: Fixes the way prefetches are handled inside the iew unit. This patch > prevents the prefetch being added to the instCommit queue twice. > > > Diffs > ----- > > src/arch/arm/faults.hh 2b5fbdcbfb5d > src/arch/arm/tlb.cc 2b5fbdcbfb5d > src/cpu/o3/iew_impl.hh 2b5fbdcbfb5d > > Diff: http://reviews.m5sim.org/r/342/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
