> On 2010-12-09 18:42:27, Ali Saidi wrote: > > src/cpu/o3/iew_impl.hh, line 1235 > > <http://reviews.m5sim.org/r/342/diff/1/?file=5460#file5460line1235> > > > > So the code outside the if block executes normally and the prefetch, if > > it faults, just silently goes away.
Oooooh, I got it now. I initially thought this was the instruction's execute method returning the fault, but now I see that's not the case (right?). This makes sense now. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/342/#review536 ----------------------------------------------------------- On 2010-12-06 16:12:26, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/342/ > ----------------------------------------------------------- > > (Updated 2010-12-06 16:12:26) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > O3: Fixes the way prefetches are handled inside the iew unit. This patch > prevents the prefetch being added to the instCommit queue twice. > > > Diffs > ----- > > src/arch/arm/faults.hh 2b5fbdcbfb5d > src/arch/arm/tlb.cc 2b5fbdcbfb5d > src/cpu/o3/iew_impl.hh 2b5fbdcbfb5d > > Diff: http://reviews.m5sim.org/r/342/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
