----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/471/#review857 -----------------------------------------------------------
I like this idea, but: 1. it would be much nicer to push this up out of the x86 code so other ISAs can use it... there's nothing x86-specific about it 2. I'd encode the panic/fatal/warn/warn_once distinction in a flag rather than as part of the type, even though that makes the call more ugly, because then you don't have to mess with the template. Having one switch statement in one rarely called function is better than what you have there IMO. 3. Do we have examples of faults that are not panics? Even hypothetical ones? If not, I'd be inclined to keep things simple by just having a bool and a string that standardizes the M5PanicFault behavior and leave the other ones out until we see that we actually need them. - Steve On 2011-02-11 08:21:47, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/471/ > ----------------------------------------------------------- > > (Updated 2011-02-11 08:21:47) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > X86: Define fault objects to carry debug messages. > > These faults can panic/warn/warn_once, etc., instead of instructions doing > that themselves directly. That way, instructions can be speculatively > executed, and only if they're actually going to commit will their fault be > invoked and the panic, etc., happen. > > > Diffs > ----- > > src/arch/x86/debugfaults.hh PRE-CREATION > src/arch/x86/isa/includes.isa 9aab11bcd84c > src/arch/x86/isa/microops/debug.isa 9aab11bcd84c > > Diff: http://reviews.m5sim.org/r/471/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
