On a side note, should warn_once be warn_once, or should it be warnOnce? I checked the style guide and it doesn't mention global functions like that. It's not a local variable which is what's supposed to use the underscores.
Gabe On 02/12/11 11:52, Gabe Black wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/471/ > > > On February 12th, 2011, 8:12 a.m., *Steve Reinhardt* wrote: > > I like this idea, but: > 1. it would be much nicer to push this up out of the x86 code so > other ISAs can use it... there's nothing x86-specific about it > 2. I'd encode the panic/fatal/warn/warn_once distinction in a flag > rather than as part of the type, even though that makes the call more ugly, > because then you don't have to mess with the template. Having one switch > statement in one rarely called function is better than what you have there > IMO. > 3. Do we have examples of faults that are not panics? Even > hypothetical ones? If not, I'd be inclined to keep things simple by just > having a bool and a string that standardizes the M5PanicFault behavior and > leave the other ones out until we see that we actually need them. > > 1. I like the idea of moving this out of x86, although practically speaking I > don't know that any other ISA would be able to use it right now. I'll still > move it though. This is, of course, talking about the faults themselves and > not the instruction objects. The instructions are x86 specific. > 2. Ok. I don't really see how it's better, but I don't think it's worse. > 3. Yes. X86 uses all those for it's debugging microops. They were brought > into existence so that those microops could be speculatively executed safely. > > - Gabe > > > On February 11th, 2011, 8:21 a.m., Gabe Black wrote: > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, > and Nathan Binkert. > By Gabe Black. > > /Updated 2011-02-11 08:21:47/ > > > Description > > X86: Define fault objects to carry debug messages. > > These faults can panic/warn/warn_once, etc., instead of instructions doing > that themselves directly. That way, instructions can be speculatively > executed, and only if they're actually going to commit will their fault be > invoked and the panic, etc., happen. > > > Diffs > > * src/arch/x86/debugfaults.hh (PRE-CREATION) > * src/arch/x86/isa/includes.isa (9aab11bcd84c) > * src/arch/x86/isa/microops/debug.isa (9aab11bcd84c) > > View Diff <http://reviews.m5sim.org/r/471/diff/> > > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
