Hi Ant,
Apologies for the slow review. Can you comment on the src files that
don't have src license headers?
I also note that the commonj src files contain the following copyright
statement. I would expect to find it in the base NOTICE file as well
as any jar files containing commonj classes...
=======================================================================
==C:/Tuscany/Distros/SDO/1.1-rc4a/tuscany-sdo-1.1-incubating-src/sdo-
api/src/main/java/commonj/sdo/ChangeSummary.java
=======================================================================
/**
* <copyright>
*
* Service Data Objects
* Version 2.1.0
* Licensed Materials
*
* (c) Copyright BEA Systems, Inc., International Business Machines
Corporation,
* Oracle Corporation, Primeton Technologies Ltd., Rogue Wave
Software, SAP AG.,
* Software AG., Sun Microsystems, Sybase Inc., Xcalia, Zend
Technologies,
* 2005, 2006. All rights reserved.
*
* </copyright>
*
*/
Everything else looked good to me.
--kevan
On Apr 6, 2008, at 7:10 PM, ant elder wrote:
Please vote to approve the 1.1 release of Tuscany SDO.
This is RC4 fixing the issues found in the previous RC2. The release
artifacts including source and binary distributions, maven staging
repository, and RAT report are at:
http://people.apache.org/~antelder/tuscany/sdo/1.1-rc4a
The tag for the release is at:
https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sdo/1.1/
KEYS file is at: https://svn.apache.org/repos/asf/incubator/tuscany/KEYS
The tuscany-dev list vote thread is at:
http://apache.markmail.org/message/xgaeb7klnsfdkrmx
Many thanks,
...ant
