On 11/04/2008, Kevan Miller <[EMAIL PROTECTED]> wrote: > > On Apr 10, 2008, at 8:42 PM, Luciano Resende wrote: > > > > The files that have this license are listed in the LICENSE [1] file > > (search for "Apache Tuscany SDO for Java Subcomponents") and I also > > see a mention of osoa.org in the NOTICE [2]. > > > > Is this what you were looking for ? > > > > For files without src license headers, I was referring to files like: > > > ==C:/Tuscany/Distros/SDO/1.1-rc4a/tuscany-sdo-1.1-incubating-src/impl/model/SDO.mdl > > ==C:/Tuscany/Distros/SDO/1.1-rc4a/tuscany-sdo-1.1-incubating-src/impl/src/test/resources/customer1.xml > ... > > Looks like most are test files. I won't quibble much about the test files. > Easiest (in the long run) to add license headers, IMO. Not sure what to make > of the SDO.mdl file. > > Yes, I saw the simple osoa.org attribution in the notice file. However, IMO > that is not sufficient. I think the NOTICE should contain the copyright info > and I believe the OSOA license requires it. From the OSOA license: > > 1. A link or URL to the Artifacts at this location: > http://www.osoa.org/display/Main/Service+Data+Objects+Specifications > > 2. The full text of this copyright notice as shown in the Artifacts. > > I would add both of those to the NOTICE file. >
The NOTICE file is for attributions only. The rest goes in the LICENSE file, as has already been done > --kevan > > > > > > > > [1] > https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sdo/1.1-RC3/LICENSE > > [2] > https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sdo/1.1-RC3/NOTICE > > > > On Thu, Apr 10, 2008 at 5:28 PM, Kevan Miller <[EMAIL PROTECTED]> > wrote: > > > > > Hi Ant, > > > Apologies for the slow review. Can you comment on the src files that > don't > > > have src license headers? > > > > > > I also note that the commonj src files contain the following copyright > > > statement. I would expect to find it in the base NOTICE file as well as > any > > > jar files containing commonj classes... > > > > > > > ======================================================================= > > > > > > > ==C:/Tuscany/Distros/SDO/1.1-rc4a/tuscany-sdo-1.1-incubating-src/sdo-api/src/main/java/commonj/sdo/ChangeSummary.java > > > > ======================================================================= > > > /** > > > * <copyright> > > > * > > > * Service Data Objects > > > * Version 2.1.0 > > > * Licensed Materials > > > * > > > * (c) Copyright BEA Systems, Inc., International Business Machines > > > Corporation, > > > * Oracle Corporation, Primeton Technologies Ltd., Rogue Wave Software, > SAP > > > AG., > > > * Software AG., Sun Microsystems, Sybase Inc., Xcalia, Zend > Technologies, > > > * 2005, 2006. All rights reserved. > > > * > > > * </copyright> > > > * > > > */ > > > > > > Everything else looked good to me. > > > > > > --kevan > > > > > > > > > On Apr 6, 2008, at 7:10 PM, ant elder wrote: > > > > > > > > > > > > > Please vote to approve the 1.1 release of Tuscany SDO. > > > > > > > > This is RC4 fixing the issues found in the previous RC2. The release > > > > artifacts including source and binary distributions, maven staging > > > > repository, and RAT report are at: > > > > > http://people.apache.org/~antelder/tuscany/sdo/1.1-rc4a > > > > > > > > The tag for the release is at: > > > > > https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sdo/1.1/ > > > > > > > > KEYS file is at: > https://svn.apache.org/repos/asf/incubator/tuscany/KEYS > > > > > > > > The tuscany-dev list vote thread is at: > > > > http://apache.markmail.org/message/xgaeb7klnsfdkrmx > > > > > > > > Many thanks, > > > > > > > > ...ant > > > > > > > > > > > > > > > > > > > > > > > > > -- > > Luciano Resende > > Apache Tuscany Committer > > http://people.apache.org/~lresende > > http://lresende.blogspot.com/ > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > For additional commands, e-mail: > [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]