On Mon, Aug 20, 2012 at 5:30 PM, Dave Fisher <dave2w...@comcast.net> wrote:
> In my mind as an IPMC member and Apache Member, this is a source release > VOTE with convenience binary artifacts. Thank you, Dave. I consider your statement to override the assertion on ooo-dev that binaries are part of the official release, and that suffices to address my concern about this specific VOTE: no ASF policy is being challenged. I withdraw my -1. > Edge case and RAT check discussion at the bottom, if that balances your vote > in either direction. I've read through a number of recent threads in the ooo-dev archives. It bothers me a bit that AFAICT the RAT report was not run prior to cutting the RC. As a "freelance" IPMC vote, I have few tools at my disposal to assess a release and I have to rely on the diligence of the PPMC with regards to IP integrity. In and of itself, RAT is just a helper, but whether it gets run is a heuristic. :) I wonder why "Run RAT" did not end up on a pre-release checklist anywhere. > Please advise about whether you think the PPMC needs to respin the VOTE > and/or the Artifacts in any way. * Sums and sigs look good for all 3 source archives. * All archives contain identical source files. * I could not find a version control tag for 3.4.1-rc2, but I was able to obtain the AOO34 branch at the specified revision 1372282; it was close, though seemingly not exact. The discrepancies are shown below. I don't believe this should block, but it would be nice to know why the differences exist. * I did not attempt to build and test, as I believe others have this covered. The one thing I want to follow up on is the outcome of the posthumous RAT audit: http://markmail.org/message/yrb4ujtj5s4poi5b > ./testgraphical/ui/java/ConvwatchGUIProject/dist/ConvwatchGUIProject.jar No idea. But it is test code, not needed for building. > ./xmlsecurity/test_docs/tools/httpserv/dist/httpserv.jar Not needed for building. It is part of a test setup for testing Certification Revocation Lists. So for the last two we should verify license. If the license allows redistribution, then I think we're fine. If not, then we need to build a new src ZIP without them. If I hear that those files pass muster, I expect to vote +1. Marvin Humphrey marvin@smokey:~/Desktop/aoo341 $ gpg --verify aoo-3.4.1-incubating-src.tar.gz.asc gpg: Signature made Fri Aug 17 09:30:40 2012 PDT using RSA key ID 51B5FDE8 gpg: Good signature from "Juergen Schnmidt <j...@apache.org>" gpg: aka "Juergen Schmidt <jogischm...@googlemail.com>" gpg: aka "Juergen Schmidt <jogischm...@gmail.com>" gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: D09F B15F 1A24 768D DF1F A29C CFEE F316 51B5 FDE8 marvin@smokey:~/Desktop/aoo341 $ gpg --verify aoo-3.4.1-incubating-src.tar.bz2.asc gpg: Signature made Fri Aug 17 09:31:06 2012 PDT using RSA key ID 51B5FDE8 gpg: Good signature from "Juergen Schnmidt <j...@apache.org>" gpg: aka "Juergen Schmidt <jogischm...@googlemail.com>" gpg: aka "Juergen Schmidt <jogischm...@gmail.com>" gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: D09F B15F 1A24 768D DF1F A29C CFEE F316 51B5 FDE8 marvin@smokey:~/Desktop/aoo341 $ gpg --verify aoo-3.4.1-incubating-src.zip.asc gpg: Signature made Fri Aug 17 09:30:07 2012 PDT using RSA key ID 51B5FDE8 gpg: Good signature from "Juergen Schnmidt <j...@apache.org>" gpg: aka "Juergen Schmidt <jogischm...@googlemail.com>" gpg: aka "Juergen Schmidt <jogischm...@gmail.com>" gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: D09F B15F 1A24 768D DF1F A29C CFEE F316 51B5 FDE8 marvin@smokey:~/Desktop/aoo341 $ shasum -c aoo-3.4.1-incubating-src.tar.gz.sha256 aoo-3.4.1-incubating-src.tar.gz: OK marvin@smokey:~/Desktop/aoo341 $ shasum -c aoo-3.4.1-incubating-src.zip.sha256 aoo-3.4.1-incubating-src.zip: OK marvin@smokey:~/Desktop/aoo341 $ shasum -c aoo-3.4.1-incubating-src.tar.bz2.sha256 aoo-3.4.1-incubating-src.tar.bz2: OK marvin@smokey:~/Desktop/aoo341 $ openssl md5 aoo-3.4.1-incubating-src.tar.gz MD5(aoo-3.4.1-incubating-src.tar.gz)= 356b8441d3bb08ffbbd76798188e8853 marvin@smokey:~/Desktop/aoo341 $ cat aoo-3.4.1-incubating-src.tar.gz.md5 356b8441d3bb08ffbbd76798188e8853 aoo-3.4.1-incubating-src.tar.gz marvin@smokey:~/Desktop/aoo341 $ openssl md5 aoo-3.4.1-incubating-src.tar.bz2 MD5(aoo-3.4.1-incubating-src.tar.bz2)= 8768256bba577f4dd97ade0032e5f5d0 marvin@smokey:~/Desktop/aoo341 $ cat aoo-3.4.1-incubating-src.tar.bz2.md5 8768256bba577f4dd97ade0032e5f5d0 aoo-3.4.1-incubating-src.tar.bz2 marvin@smokey:~/Desktop/aoo341 $ openssl md5 aoo-3.4.1-incubating-src.zip MD5(aoo-3.4.1-incubating-src.zip)= 5a61227c387827f04fda68a750ccdf9d marvin@smokey:~/Desktop/aoo341 $ cat aoo-3.4.1-incubating-src.zip.md5 5a61227c387827f04fda68a750ccdf9d aoo-3.4.1-incubating-src.zip marvin@smokey:~/Desktop/aoo341 $ diff -ur bz2/aoo-3.4.1/ tgz/aoo-3.4.1/ marvin@smokey:~/Desktop/aoo341 $ diff -urw bz2/aoo-3.4.1/ zip/aoo-3.4.1/ marvin@smokey:~/Desktop/aoo341 $ diff -ur exported/ext_libraries/ tgz/aoo-3.4.1/ext_libraries/ marvin@smokey:~/Desktop/aoo341 $ diff -ur exported/extras/ tgz/aoo-3.4.1/extras/ marvin@smokey:~/Desktop/aoo341 $ diff -ur exported/main/ tgz/aoo-3.4.1/main/ Only in exported/main/: .gitignore Only in exported/main/: .hgignore Only in exported/main/: .hgtags Only in tgz/aoo-3.4.1/main/: Makefile Only in exported/main/solenv: unxmacxp Only in exported/main/testgraphical/references: unxlngi Only in exported/main/testgraphical/references: unxsoli Only in exported/main/testgraphical/references: wntmsci Only in exported/main/toolkit/workben/layout: .gitignore diff -ur exported/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx tgz/aoo-3.4.1/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx --- exported/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx 2012-05-31 05:59:10.000000000 -0700 +++ tgz/aoo-3.4.1/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx 2012-08-14 07:18:47.000000000 -0700 @@ -511,6 +511,7 @@ DataFlavorMapper::DataFlavorMapper() { + fprintf(stderr, "### constructor DataFlavorMapper\n"); Reference<XMultiServiceFactory> mrServiceManager = vcl::unohelper::GetMultiServiceFactory(); mrXMimeCntFactory = Reference<XMimeContentTypeFactory>(mrServiceManager->createInstance( OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.datatransfer.MimeContentTypeFactory"))), UNO_QUERY); @@ -521,6 +522,7 @@ DataFlavorMapper::~DataFlavorMapper() { + fprintf(stderr, "### destructor DataFlavorMapper\n"); // release potential NSStrings for( OfficeOnlyTypes::iterator it = maOfficeOnlyTypes.begin(); it != maOfficeOnlyTypes.end(); ++it ) { @@ -547,8 +549,12 @@ // look if this might be an internal type; if it comes in here it must have // been through openOfficeToSystemFlavor before, so it should then be in the map rtl::OUString aTryFlavor( NSStringToOUString( systemDataFlavor ) ); - if( maOfficeOnlyTypes.find( aTryFlavor ) != maOfficeOnlyTypes.end() ) + + rtl::OString testFlavor( rtl::OUStringToOString(aTryFlavor, RTL_TEXTENCODING_UTF8) ); + fprintf(stderr, "# systemToOpenOfficeFlavor # %s\n", testFlavor.getStr()); + if( maOfficeOnlyTypes.find( aTryFlavor ) != maOfficeOnlyTypes.end() ) { + fprintf(stderr, "# systemToOpenOfficeFlavor ### found %s\n", testFlavor.getStr()); oOOFlavor.MimeType = aTryFlavor; oOOFlavor.HumanPresentableName = rtl::OUString(); oOOFlavor.DataType = CPPUTYPE_SEQINT8; @@ -569,14 +575,20 @@ } } + rtl::OString testMime( rtl::OUStringToOString(oOOFlavor.MimeType, RTL_TEXTENCODING_UTF8) ); if( ! sysFlavor ) { OfficeOnlyTypes::const_iterator it = maOfficeOnlyTypes.find( oOOFlavor.MimeType ); - if( it == maOfficeOnlyTypes.end() ) + if( it == maOfficeOnlyTypes.end() ) { + fprintf(stderr, "# openOfficeToSystemFlavor #if: %s\n", testMime.getStr()); sysFlavor = maOfficeOnlyTypes[ oOOFlavor.MimeType ] = OUStringToNSString( oOOFlavor.MimeType ); - else - sysFlavor = it->second; - } + } else { + fprintf(stderr, "# openOfficeToSystemFlavor #else: %s\n", testMime.getStr()); + sysFlavor = it->second; + } + } else + fprintf(stderr, "# openOfficeToSystemFlavor #else 2: %s\n", testMime.getStr()); + return sysFlavor; } @@ -585,6 +597,11 @@ { NSArray *supportedTypes = [NSArray arrayWithObjects: NSTIFFPboardType, NSPICTPboardType, nil]; NSString *sysFlavor = [pPasteboard availableTypeFromArray:supportedTypes]; + + rtl::OUString testUFlavor( NSStringToOUString( sysFlavor ) ); + rtl::OString testFlavor( rtl::OUStringToOString(testUFlavor, RTL_TEXTENCODING_UTF8) ); + fprintf(stderr, "# openOfficeImageToSystemFlavor # %s\n", testFlavor.getStr()); + return sysFlavor; } @@ -711,10 +728,12 @@ } else { + fprintf(stderr, "# DataFlavorMapper::flavorSequenceToTypesArray # else\n"); NSString* str = openOfficeToSystemFlavor(flavors[i]); if (str != NULL) { + fprintf(stderr, "# DataFlavorMapper::flavorSequenceToTypesArray # if str!=NULL\n"); [str retain]; [array addObject: str]; } @@ -724,7 +743,7 @@ // #i89462# #i90747# // in case no system flavor was found to report // report at least one so D&D between OOo targets works - if( [array count] == 0 ) +// if( [array count] == 0 ) { [array addObject: PBTYPE_DUMMY_INTERNAL]; } diff -ur exported/main/vcl/aqua/source/dtrans/OSXTransferable.cxx tgz/aoo-3.4.1/main/vcl/aqua/source/dtrans/OSXTransferable.cxx --- exported/main/vcl/aqua/source/dtrans/OSXTransferable.cxx 2011-11-06 01:26:39.000000000 -0800 +++ tgz/aoo-3.4.1/main/vcl/aqua/source/dtrans/OSXTransferable.cxx 2012-08-14 06:27:33.000000000 -0700 @@ -78,8 +78,10 @@ Any SAL_CALL OSXTransferable::getTransferData( const DataFlavor& aFlavor ) throw( UnsupportedFlavorException, IOException, RuntimeException ) { + fprintf(stderr, "# OSXTransferable::getTransferData\n"); if (!isValidFlavor(aFlavor) || !isDataFlavorSupported(aFlavor)) { + fprintf(stderr, "# OSXTransferable::getTransferData# throw UnsupportedFlavorException\n"); throw UnsupportedFlavorException(OUString(RTL_CONSTASCII_USTRINGPARAM("AquaClipboard: Unsupported data flavor")), static_cast<XTransferable*>(this)); } @@ -92,11 +94,13 @@ if ([sysFormat caseInsensitiveCompare: NSFilenamesPboardType] == NSOrderedSame) { + fprintf(stderr, "# OSXTransferable::getTransferData # if\n"); NSArray* sysData = [mPasteboard propertyListForType: sysFormat]; dp = mDataFlavorMapper->getDataProvider(sysFormat, sysData); } else { + fprintf(stderr, "# OSXTransferable::getTransferData # else\n"); NSData* sysData = [mPasteboard dataForType: sysFormat]; dp = mDataFlavorMapper->getDataProvider(sysFormat, sysData); } diff -ur exported/main/vcl/aqua/source/dtrans/aqua_clipboard.cxx tgz/aoo-3.4.1/main/vcl/aqua/source/dtrans/aqua_clipboard.cxx --- exported/main/vcl/aqua/source/dtrans/aqua_clipboard.cxx 2011-11-06 01:26:39.000000000 -0800 +++ tgz/aoo-3.4.1/main/vcl/aqua/source/dtrans/aqua_clipboard.cxx 2012-08-14 06:44:22.000000000 -0700 @@ -189,6 +189,8 @@ mpDataFlavorMapper->flavorSequenceToTypesArray(xTransferable->getTransferDataFlavors()) : [NSArray array]; + int l = [types count]; + fprintf(stderr, "# AquaClipboard::setContents # %d\n", l); ClearableMutexGuard aGuard(m_aMutex); Reference<XClipboardOwner> oldOwner(mXClipboardOwner); @@ -339,8 +341,10 @@ void SAL_CALL AquaClipboard::flushClipboard() throw(RuntimeException) { + fprintf(stderr, "#### AquaClipboard::flushClipboard\n"); if (mXClipboardContent.is()) { + fprintf(stderr, "#### AquaClipboard::flushClipboard # mXClipboardContent.is() \n"); Sequence<DataFlavor> flavorList = mXClipboardContent->getTransferDataFlavors(); sal_uInt32 nFlavors = flavorList.getLength(); @@ -350,8 +354,10 @@ if (sysType != NULL) { + fprintf(stderr, "#### AquaClipboard::flushClipboard # sysType != NULL\n"); provideDataForType(mPasteboard, sysType); - } + } else + fprintf(stderr, "#### AquaClipboard::flushClipboard # sysType == NULL\n"); } mXClipboardContent.clear(); } marvin@smokey:~/Desktop/aoo341 $ --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org