Thanks Matt for pointing that out, good to know. I have created a Jira to consider that option: https://issues.apache.org/jira/browse/GOBBLIN-449 However, I am wondering if this is a deal breaker for the release? Or, can we use the current process that we have adopted since it works well for our users, and follows a pre-existing Apache model of Apache Fineract.
Abhishek On Tue, Mar 27, 2018 at 10:44 AM, Matthew Hayes < matthew.terence.ha...@gmail.com> wrote: > Abhishek, what about using a bootstrap gradle task to download the jar and > gradlew? DataFu does this [1], which was based on Samza's solution. You > just need to have some version of gradle installed and can run `gradle -b > bootstrap.gradle`. Then you don't need the jar or gradlew checked in. > > -Matt > > [1]https://github.com/apache/datafu/blob/master/bootstrap.gradle > > On Tue, Mar 27, 2018 at 10:30 AM, Abhishek Tiwari <a...@apache.org> wrote: > > > Yes, I understand that gradle-wrapper.jar is a convenience jar that helps > > get the gradle. > > However, we could not include it in the distribution because it is not > > acceptable to include binaries and instead we went with the proposed > > resolution in this thread: > > https://issues.apache.org/jira/browse/LEGAL-288? > focusedCommentId=15980830& > > page=com.atlassian.jira.plugin.system.issuetabpanels% > > 3Acomment-tabpanel#comment-15980830 > > > > > > This is (almost) exactly the same as what Apache Fineract does to address > > the same: > > - https://github.com/apache/fineract/blob/develop/README.md > > - > > https://www.mail-archive.com/dev@gobblin.incubator.apache. > > org/msg01727.html > > I like the Fineract model, especially because it requires only one extra > > step than what would be required otherwise to build the distribution. > > However, we will continue to improve upon the build process in future. > > > > We have not moved to newer versions of gradle yet, and we specify the > > gradle version requirement in README.md. > > > > Abhishek > > > > On Tue, Mar 27, 2018 at 10:06 AM, Matt Sicker <boa...@gmail.com> wrote: > > > > > I'd suggest not including gradlew and gradlew.bat in your source > > > distribution then. You are aware that gradle-wrapper.jar is itself a > > > bootstrap jar to get gradle itself, right? It's tiny and generally > > bundled > > > with source code for convenience. As an aside, in order to regenerate > the > > > gradle wrapper the normal way (gradle wrapper --gradle-version 2.13), I > > had > > > to run it outside the project since the latest version of gradle is > > > incompatible, too. :/ > > > > > > On 27 March 2018 at 11:46, Abhishek Tiwari <a...@apache.org> wrote: > > > > > > > Hi Matt, > > > > > > > > Thanks for checking. We intentionally do not bundle > gradle-wrapper.jar, > > > and > > > > instead document the steps to obtain it and build. > > > > Please check the included README.md file. > > > > > > > > Regards, > > > > Abhishek > > > > > > > > On Tue, Mar 27, 2018 at 8:18 AM, Matt Sicker <boa...@gmail.com> > wrote: > > > > > > > > > The bundled gradle wrapper in the source tgz doesn't work. It > appears > > > to > > > > be > > > > > missing gradle/wrapper/gradle-wrapper.jar > > > > > > > > > > On 26 March 2018 at 19:01, Abhishek Tiwari <a...@apache.org> > wrote: > > > > > > > > > > > The Apache Gobblin community has voted on and approved the > release > > of > > > > > > Apache Gobblin 0.12.0 (incubating): > > > > > > > > > > > > https://www.mail-archive.com/dev@gobblin.incubator.apache. > > > > > > org/msg01772.html > > > > > > > > > > > > Results: > > > > > > 5 binding +1 votes > > > > > > No 0 votes > > > > > > No -1 votes > > > > > > > > > > > > The feedback from previous release candidates has been addressed: > > > > > > RC0 thread: https://www.mail-archive.com/general@incubator. > > > > > > apache.org/msg62151.html > > > > > > RC0 resolution: LICENSE and NOTICE files have been updated > (tracked > > > by > > > > > > GOBBLIN-431 <https://issues.apache.org/jira/browse/GOBBLIN-431>) > > > > > > RC1 thread: https://www.mail-archive.com/dev@gobblin. > > > > > > incubator.apache.org/msg01733.html > > > > > > RC1 resolution: gradlew scripts have been included in the source > > > > > > distribution, and the steps for building the distribution has > been > > > > added > > > > > to > > > > > > README (including the way to obtain gradlew jar) > > > > > > > > > > > > I'd like to call a vote in general to approve the release. > > > > > > > > > > > > The source release candidate RC2 can be downloaded here: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/gobblin/ > > > > > > apache-gobblin-incubating-0.12.0-rc2/ > > > > > > > > > > > > The artifacts (i.e. JARs) corresponding to this release candidate > > can > > > > be > > > > > > found here: > > > > > > > > > > > > https://repository.apache.org/content/repositories/ > > > > orgapachegobblin-1002 > > > > > > > > > > > > This has been signed with PGP key 234E3FE3, corresponding to > > > > > > a...@apache.org, which is included in the repository's KEYS > file ( > > > > > > https://dist.apache.org/repos/dist/release/incubator/ > gobblin/KEYS > > ). > > > > > This > > > > > > key can be found on keyservers, such as: > > > > > > > > > > > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3 > > > > > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>* > > > > > > > > > > > > It is also listed here: > > > > > > > > > > > > https://people.apache.org/keys/committer/abti.asc > > > > > > > > > > > > The release candidate has been tagged with release-0.12.0-rc2. > > > > > > I've also created a branch 0.12.0. > > > > > > > > > > > > For reference, here is a list of all closed JIRAs tagged with > > 0.12.0: > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20% > > > > > 3D%20GOBBLIN%20AND% > > > > > > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed% > > > > > > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C% > > > > > > 20createdDate%20DESC%2C% > > > > > > 20status%20DESC%2C%20priority%20DESC > > > > > > > > > > > > For a summary of the changes in this release, see: > > > > > > > > > > > > https://github.com/apache/incubator-gobblin/blob/0.12.0/ > > CHANGELOG.md > > > > > > > > > > > > Please review and vote. The vote will be open for 72 hours. > > > > > > > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > > > Thanks, > > > > > > Abhishek, on behalf of the Apache Gobblin PPMC > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Matt Sicker <boa...@gmail.com> > > > > > > > > > > > > > > > > > > > > > -- > > > Matt Sicker <boa...@gmail.com> > > > > > >
