Hi Justin Thanks for the checking and guidances. I'd cancel this vote here, will re-initiate a vote after solved the problems you indicated. Thanks again for helping Linkis become a better, more Apache Way compliant project :)
Regarding the issue you mentioned, we will make the following improvements: 1. I also notice you have 5 mentors, have you asked them to check the release? Yes, we have request mentors to check the 1.1.1-RC1 version. 2. LICENSE is missing license from files in this zip It’s looks like they are under the PSF License not the BSD license. The license of the file py4j-0.10.7-src.zip does specify the BSD license on their official website [1] We specify py4j-0.10.7-src.zip in the LICENSE file under BSD licenses [2][3] 3. A binary file containing compelled code exists in the source release Referring to the "the case of the maven wrapper" mail discussed[4],We will remove the maven-wrapper.jar file from the source release 4. BTW Also looks like mvnw has the wrong line endings. Thanks, we will fix this encoding issue Kind Regards, PeaceWong 1. https://github.com/py4j/py4j/tree/0.10.7 2. https://github.com/apache/incubator-linkis/blob/release-1.1.1-rc1/LICENSE 3. https://github.com/apache/incubator-linkis/blob/release-1.1.1-rc1/linkis-engineconn-plugins/engineconn-plugins/python/src/main/py4j/LICENSE-py4j-0.10.7-src.txt 4. https://lists.apache.org/thread/rwzlx5l0046rcl4zz92m0q8p3mn1xc6r Justin Mclean <jus...@classsoftware.com> 于2022年5月13日周五 12:07写道： > Hi, > > Sorry but it’s -1 binding from me as there a binary in the source release. > There’s also a minor license issue. > > I also notice you have 5 mentors, have you asked them to check the release? > > It also looks like to me that the binary license and notice file are > listing all dependancies rather than only what is included in those > releases but I didn’t do a detailed check. > > I checked: > - incubating in release name > - DISCLAIMER exits > - LICENSE is missing license from files in this zip [2] It’s looks like > they are under the PSF License not the BSD license. > - NOTICE is fine > - All files have ASF headers except where noted > - A binary file containing compelled code exists in the source release [1] > - I was able to compile from source > > It would be nice to see some instruction on compiling in the README. > Putting a link to a webpage may not work in the future as the contents of > that page are likely to change over time. > > BTW Also looks like mvnw has the wrong line endings. > ./mvnw > -bash: ./mvnw: /bin/sh^M: bad interpreter: No such file or directory > > Kind Regards, > Justin > > 1. ./.mvn/wrapper/maven-wrapper.jar > 2. > ./linkis-engineconn-plugins/engineconn-plugins/python/src/main/py4j/py4j-0.10.7-src.zip > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
