Justin Deoliveira ha scritto: > Hi Andrea, > > I am kind of puzzled why I am not seeing any patches for any of this, or > at least a wait for some feedback. This is pretty core stuff you are > changing, and I would like a chance to comment on it before it gets > committed. I believe this was part of the new process we agreed on, no?
I was so upset with the obvious disregard of the most basics performance considerations that went and fix without thinking. I have spent days and nights on performance tuning of the streaming renderer, and now these changes blew up my work and make me do more in order to get back some (but not all) of the performance you can get on 2.3.x Yet, if you look at my patches, you'll see the changes are pretty minimal, I did not change the current design, just added some caching the very same way FunctionExpressions are cached, made Patterns compile just once, and avoided code styles like: new PropertyAccessors().findPropertyAccessor( feature, attPath, null, null ); by replacing these with a real static function call (and forgot to replace . I did not remove the Value class, although it falls in the same category (static function call hidden behind object creation, as if creating object had 0 cost). I did not change the property accessors lookup code, because it requires redesign, and this needs discussion. So, I don't sincerely think any of the patches I committed needed to go thru an API change process, but please, have a look at the patches here: http://www.nabble.com/svn---r24344---in-geotools-trunk-gt-modules-library-render-src-main-java-org-geotools-renderer%3A-lite-style-tf3210557.html http://www.nabble.com/svn---r24343---geotools-trunk-gt-modules-library-main-src-main-java-org-geotools-filter-expression-tf3210549.html http://www.nabble.com/svn---r24342---in-geotools-trunk-gt-modules-library-main-src-main-java-org-geotools-filter%3A-.-expression-tf3210545.html and tell me which of these required a big discussion before being committed. Or tell me which of these looks like a temporary hack that just hides a design problem. There are issues in the above commits, I did reformat by accident a small file, and could have waited before turning PropertyAccessors into a singleton, but nothing like the things I've been accused of as far as I can see. Cheers Andrea ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
