Well it is not super important ... can you just talk me through this second code example:
import org.geotools.coverage.grid.GeneralGridEnvelope; GridEnvelope2D originalGridRange=... final int w = originalGridRange.getSpan(0); final int maxx = originalGridRange.getHigh(0)+1; GridEnvelope2D originalGridRange2D=... final Rectangle rect = (Rectangle)originalGridRange2D; You have an import of GeneralGridEnvelope but then never use it; and I am not sure what kind of methods produce a GridEnvelope2D; I do get that you can cast it to a Rectangle now; is that part of it being an envelope (in which case how do you choose which axis are width and height); or is it part of it being this specific GridEnvelope2D implementation. Jody On Fri, May 15, 2009 at 12:42 AM, Simone Giannecchini <simone.giannecch...@geo-solutions.it> wrote: > Well, ask away so that we can clarify. > > Simone. > ------------------------------------------------------- > Ing. Simone Giannecchini > GeoSolutions S.A.S. > Owner - Software Engineer > Via Carignoni 51 > 55041 Camaiore (LU) > Italy > > phone: +39 0584983027 > fax: +39 0584983027 > mob: +39 333 8128928 > > > http://www.geo-solutions.it > http://simboss.blogspot.com/ > http://www.linkedin.com/in/simonegiannecchini > > ------------------------------------------------------- > > > > On Thu, May 14, 2009 at 4:37 PM, Jody Garnett <jody.garn...@gmail.com> wrote: >> I see; in general for this kind of "technical debt" stuff we may not >> need a change proposal; especially as you are now the module >> maintainer. There is nothing stratigic here right - just trying to >> clean up work that was not completed. >> >> So while I still do not feel I get it; the reference to a 2d data >> structure troubles me some (and it sounds like that is a coversation >> for another day); I can vote +1 to get you moving. >> >> Jody >> >> On Fri, May 15, 2009 at 12:33 AM, Simone Giannecchini >> <simone.giannecch...@geo-solutions.it> wrote: >>> Ciao Jody, >>> the problem is that there is not much to understand :-). >>> I am trying to clean up a work left halfway, triggere by an unilateral >>> change in geoapi. >>> To simplify, in the past we where using GridRange implementations then >>> all at a sudden I notice that they were deprecated and replaced with >>> something (GridEnvelope) similar but not exactly interchangeable. >>> Now I want to remove the duplication on go on with just one set of classes. >>> >>> This proposal has not 2d vs Nd implications, it is a simple clean up >>> of what we have. >>> >>> Simone. >>> ------------------------------------------------------- >>> Ing. Simone Giannecchini >>> GeoSolutions S.A.S. >>> Owner - Software Engineer >>> Via Carignoni 51 >>> 55041 Camaiore (LU) >>> Italy >>> >>> phone: +39 0584983027 >>> fax: +39 0584983027 >>> mob: +39 333 8128928 >>> >>> >>> http://www.geo-solutions.it >>> http://simboss.blogspot.com/ >>> http://www.linkedin.com/in/simonegiannecchini >>> >>> ------------------------------------------------------- >>> >>> >>> >>> On Thu, May 14, 2009 at 4:25 PM, Jody Garnett <jody.garn...@gmail.com> >>> wrote: >>>> I do not feel I understand what this change covers ... what is this >>>> data structure used for - >>>> I am trying to pick up some context here; it appears as if the >>>> replacement is 2d only? GridEnvelope2D >>>> >>>> Are we not trying for a multiple dimensional expression of range here? >>>> rectangle has getWidth and getHeight; and I am expecting getSpan(0), >>>> getSpan(1), getSpan( n ) etc... >>>> >>>> I am not sure I understand the proposal :( I of course do not >>>> understand why it was changed suddenly either... >>>> >>>> Jody >>>> >>>> On Thu, May 14, 2009 at 11:12 PM, Simone Giannecchini >>>> <simone.giannecch...@geo-solutions.it> wrote: >>>>> Ciao guys, >>>>> I have been putting together this proposal: >>>>> >>>>> http://docs.codehaus.org/display/GEOTOOLS/GridEnvelope+subclasses+replacing+deprecated+GridRange+subclasses >>>>> >>>>> to start cleaning up things in geotools coverage module. This time is >>>>> the turn of GridRange subclasses which become deprecated all of a >>>>> sudden last summer with very little communication. >>>>> While my intent here is not to discuss the dependency on GeoApi as a >>>>> whole but I am assuming that for the time being we will keep that >>>>> dependency around I would like to remove all the references to the >>>>> GeneralGridRange and GridRange2D classes and substituting them with >>>>> their pairings GeneralGridEnvelope and GridEnvelope2D on both gt trunk >>>>> and gs trunk. >>>>> >>>>> I have already done the work and run test for geoserver and geotools >>>>> with success. Notice that I have replaced the above classes, >>>>> everywhere, not only inside my own plugins (yeah, I am talking to you >>>>> gabriel and chri stian :-) ). >>>>> >>>>> So, please, cast your vote, before the work done start to smell bad on >>>>> my hd :-). >>>>> >>>>> Ciao, >>>>> Simone. >>>>> >>>>> >>>>> ------------------------------------------------------- >>>>> Ing. Simone Giannecchini >>>>> GeoSolutions S.A.S. >>>>> Owner - Software Engineer >>>>> Via Carignoni 51 >>>>> 55041 Camaiore (LU) >>>>> Italy >>>>> >>>>> phone: +39 0584983027 >>>>> fax: +39 0584983027 >>>>> mob: +39 333 8128928 >>>>> >>>>> >>>>> http://www.geo-solutions.it >>>>> http://simboss.blogspot.com/ >>>>> http://www.linkedin.com/in/simonegiannecchini >>>>> >>>>> ------------------------------------------------------- >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your >>>>> production scanning environment may not be a perfect world - but thanks to >>>>> Kodak, there's a perfect scanner to get the job done! With the NEW KODAK >>>>> i700 >>>>> Series Scanner you'll get full speed at 300 dpi even with all image >>>>> processing features enabled. http://p.sf.net/sfu/kodak-com >>>>> _______________________________________________ >>>>> Geotools-devel mailing list >>>>> Geotools-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>>> >>>> >>>> >>> >> >> ------------------------------------------------------------------------------ >> The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your >> production scanning environment may not be a perfect world - but thanks to >> Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 >> Series Scanner you'll get full speed at 300 dpi even with all image >> processing features enabled. http://p.sf.net/sfu/kodak-com >> _______________________________________________ >> Geotools-devel mailing list >> Geotools-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> > ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
