Hi Ben,
>
> (2) Please look at the logic in SchemaCache.startDownload(). Why is it
> necessary to create an empty file? How should SchemaCache recover when a
> download fails? Please have a look and recommend a solution. I know you
> gave this some thought and I do not want to introduce a deadlock or thread
> blocking that might impact your performance.
>
>
I had a look at the code, and the empty file creation seems not useful in
that point. I don't remember why I introduced it. Maybe it was there for
some file existance check, but that check is not there anymore. So I'm
going to remove the empty file creation completely. The connect timeout
instead was there to prevent a deadlock. I'm going to make it configurable
through an env variable (-Dschema.cache.download.timeout is ok for you?).
For the default, maybe we can set it to 30seconds. What do you think?
Mauro
--
==
GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.
==
Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
