2013/5/24 Ben Caradoc-Davies <[email protected]>

> Mauro, I do not like the exception swallowing in SchemaCache.download().
> You changed to original:
>
> throw new RuntimeException(e);
>
> to
>
> return null;
>

You are right, please have a look at my new commit:
https://github.com/mbarto/geotools/commit/d81f9f2dbaf549c6a0b47fda96bfef4bfccf2695

I introduced a checked exception (IOException) so that I'm able to catch it
and call endDownload also in case of failure (this was the reason I removed
the throw in my first commit).

I also updated the downloadTimeout to 60 seconds (for paranoids :-) ).

Mauro


-- 
==
GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.
==

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:     +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to