klcopp commented on a change in pull request #1735:
URL: https://github.com/apache/hive/pull/1735#discussion_r536079340
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -561,12 +561,12 @@ protected Boolean findNextCompactionAndExecute(boolean
computeStats) throws Inte
} catch (Throwable e) {
LOG.error("Caught exception while trying to compact " + ci +
". Marking failed to avoid repeated failures", e);
- abortCompactionAndMarkFailed(ci, compactorTxnId, e);
+ compactorTxnId = abortCompactionAndMarkFailed(ci, compactorTxnId, e);
}
} catch (TException | IOException t) {
LOG.error("Caught an exception in the main loop of compactor worker " +
workerName, t);
try {
- abortCompactionAndMarkFailed(ci, compactorTxnId, t);
+ compactorTxnId = abortCompactionAndMarkFailed(ci, compactorTxnId, t);
Review comment:
I thought that this way it would be more obvious to future developers
that the compactorTxnId needs to be unset every time it's aborted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
