pvary commented on a change in pull request #1735:
URL: https://github.com/apache/hive/pull/1735#discussion_r541113701
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -636,4 +621,66 @@ private static boolean isDynPartAbort(Table t,
CompactionInfo ci) {
return t.getPartitionKeys() != null && t.getPartitionKeys().size() > 0
&& ci.partName == null;
}
+
+ /**
+ * Keep track of the compaction's transaction and its operations.
+ */
+ private class CompactionTxn {
Review comment:
What if we extend AutoCloseable?
Then we can use the try withresource without finally magic. And close could
say - if needed commit.
I think this is the last comment.
How do you like this code? Is it better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
