klcopp commented on a change in pull request #1735:
URL: https://github.com/apache/hive/pull/1735#discussion_r540841418
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -579,7 +567,7 @@ protected Boolean findNextCompactionAndExecute(boolean
computeStats) throws Inte
} catch (Throwable t) {
LOG.error("Caught an exception in the main loop of compactor worker " +
workerName, t);
} finally {
- commitTxnIfSet(compactorTxnId);
+ compactionTxn.commit();
Review comment:
If compaction failed, it should be aborted before this.
CompactionTxn#commit will only commit the txn if it's still open.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
