pvary commented on a change in pull request #1735:
URL: https://github.com/apache/hive/pull/1735#discussion_r540796283
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -483,12 +471,12 @@ protected Boolean findNextCompactionAndExecute(boolean
computeStats) throws Inte
* multiple statements in it (for query based compactor) which is not
supported (and since
* this case some of the statements are DDL, even in the future will not
be allowed in a
* multi-stmt txn. {@link Driver#setCompactionWriteIds(ValidWriteIdList,
long)} */
- compactorTxnId = msc.openTxn(ci.runAs, TxnType.COMPACTION);
+ compactionTxn.open(ci);
- heartbeater = new CompactionHeartbeater(compactorTxnId, fullTableName,
conf);
+ heartbeater = new CompactionHeartbeater(compactionTxn.getTxnId(),
fullTableName, conf);
Review comment:
Maybe change compactionHeartbeater to use the new class instead of Id?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
