saihemanth-cloudera commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1154425672
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2070,18 +2096,30 @@ struct CreateDatabaseRequest {
8: optional string catalogName,
9: optional i32 createTime,
10: optional string managedLocationUri,
- 11: optional string type,
- 12: optional string dataConnectorName
+ 11: optional DatabaseType type,
+ 12: optional string dataConnectorName,
+ 13: optional string remote_dbname
Review Comment:
I'm trying to point to create_database_req(req) instead of
create_database(database), by converting the database object to a request
object. As a result, I had to introduce whatever is in the database object to
the CreateDatabaseRequest object. If this is not a good change, what do you
suggest I should be doing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
