saihemanth-cloudera commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1154441856
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2236,9 +2282,9 @@ struct GetSchemaResponse {
struct GetPartitionRequest {
1: optional string catName,
- 2: required string dbName,
- 3: required string tblName,
- 4: required list<string> partVals,
+ 2: optional string dbName,
Review Comment:
2 reasons. 1) ease of use in HMSClient 2) Tests are sending null values in
these required values and as a result, the request won't even land on HMS.
But both reasons are defeating the whole objective as these 3 values are
always required. I'll handle the null values in the HMS client and keep these
values as required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
